Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tidy] Add stylelint rule to flag unmatched CSS properties #898

Merged
merged 68 commits into from
Nov 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
68 commits
Select commit Hold shift + click to select a range
81eeb60
Add changes
huong-li-nguyen Nov 18, 2024
5f0e020
Update latest CSS file
huong-li-nguyen Nov 19, 2024
fff42a1
Remove CSS for tooltip
huong-li-nguyen Nov 19, 2024
07d8929
Update vizro-bootstrap.min.css
huong-li-nguyen Nov 19, 2024
0a7ff33
Create 20241119_155853_huong_li_nguyen_add_bs_tooltip_styling.md
huong-li-nguyen Nov 19, 2024
7abbbbf
Merge branch 'main' into tidy/add-bs-tooltip-styling
huong-li-nguyen Nov 19, 2024
480914d
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 19, 2024
4a598a2
Remove all CSS variables
huong-li-nguyen Nov 19, 2024
39032be
Rename variables with vizro-bs equivalent
huong-li-nguyen Nov 19, 2024
1ca73f8
Replace with rem units
huong-li-nguyen Nov 19, 2024
610a188
Hardcode values where suitable
huong-li-nguyen Nov 19, 2024
96464d6
Add back selected variables
huong-li-nguyen Nov 19, 2024
e35fe36
Replace matched values
huong-li-nguyen Nov 19, 2024
3404355
Replace remaining values
huong-li-nguyen Nov 19, 2024
4d07ec0
Create 20241119_173819_huong_li_nguyen_remove_variables.md
huong-li-nguyen Nov 19, 2024
5a47f97
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 19, 2024
e7cdc9b
Merge branch 'tidy/add-bs-tooltip-styling' into tidy/remove-variables
huong-li-nguyen Nov 19, 2024
1277f11
Merge branch 'tidy/remove-variables' of https://github.com/mckinsey/v…
huong-li-nguyen Nov 19, 2024
b52fb72
Fix collapse bg color
huong-li-nguyen Nov 20, 2024
42bdb3a
Update color
huong-li-nguyen Nov 20, 2024
0742dc8
Fix renaming of border
huong-li-nguyen Nov 20, 2024
ba273f7
Replace remaining variable mentions
huong-li-nguyen Nov 20, 2024
307ce5c
Merge branch 'main' into tidy/remove-variables
huong-li-nguyen Nov 20, 2024
84d5d73
Update CSS variables outside of static folder
huong-li-nguyen Nov 21, 2024
2ec7c6e
Revert demo changes
huong-li-nguyen Nov 21, 2024
9ff9e3d
Update CSS variables
huong-li-nguyen Nov 21, 2024
4fac651
Update changelog
huong-li-nguyen Nov 21, 2024
c77fd12
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 21, 2024
f09f7b6
Update vizro version
huong-li-nguyen Nov 21, 2024
0065779
Update requirements
huong-li-nguyen Nov 21, 2024
5d1034d
Add requirements for `dev`
huong-li-nguyen Nov 21, 2024
28ae503
Add banner
huong-li-nguyen Nov 21, 2024
dc498ef
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 21, 2024
f9bba27
Update table
huong-li-nguyen Nov 21, 2024
bf90f2c
Merge branch 'main' into tidy/remove-variables
huong-li-nguyen Nov 21, 2024
e0c9f20
Fix tabs
huong-li-nguyen Nov 21, 2024
96fcd96
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 21, 2024
f8ab934
Rename file
huong-li-nguyen Nov 21, 2024
5e7b3b1
Merge branch 'tidy/remove-variables' into demo/update-css-variables
huong-li-nguyen Nov 21, 2024
4431186
Fix dashboard-ui
huong-li-nguyen Nov 21, 2024
73c55c5
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 21, 2024
4600223
Merge branch 'main' into tidy/remove-variables
huong-li-nguyen Nov 25, 2024
de7781e
Clarify comment
huong-li-nguyen Nov 25, 2024
7b3e2e3
Add comment
huong-li-nguyen Nov 25, 2024
34a74e3
Merge branch 'tidy/remove-variables' into demo/update-css-variables
huong-li-nguyen Nov 25, 2024
9358742
Update docs
huong-li-nguyen Nov 26, 2024
e9be97e
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 26, 2024
c18f942
Lint
huong-li-nguyen Nov 26, 2024
a9dd04d
Merge branch 'tidy/remove-variables' of https://github.com/mckinsey/v…
huong-li-nguyen Nov 26, 2024
06f93df
Merge branch 'tidy/remove-variables' into demo/update-css-variables
huong-li-nguyen Nov 26, 2024
26046be
Update
huong-li-nguyen Nov 26, 2024
bf1a006
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 26, 2024
aaf36a3
Fix typo
huong-li-nguyen Nov 26, 2024
d6c2aaf
Merge branch 'tidy/remove-variables' into demo/update-css-variables
huong-li-nguyen Nov 26, 2024
bbff0a4
Merge branch 'main' into demo/update-css-variables
huong-li-nguyen Nov 26, 2024
06ceaed
Merge branch 'main' into demo/update-css-variables
huong-li-nguyen Nov 26, 2024
f2af917
Update assets folder for dev
huong-li-nguyen Nov 27, 2024
15d6e6e
Fix integration tests
huong-li-nguyen Nov 27, 2024
9811a82
Add plugin
huong-li-nguyen Nov 27, 2024
7b88c56
Fix remaining unmatched properties
huong-li-nguyen Nov 27, 2024
e2ce378
Tidy
huong-li-nguyen Nov 27, 2024
32a9043
Merge branch 'demo/update-css-variables' into tidy/test-stylelint-plugin
huong-li-nguyen Nov 27, 2024
2f62d11
Update custom.css
huong-li-nguyen Nov 27, 2024
c1dd4b7
Merge branch 'main' into tidy/test-stylelint-plugin
huong-li-nguyen Nov 27, 2024
db66e4f
Merge branch 'main' into tidy/test-stylelint-plugin
huong-li-nguyen Nov 28, 2024
6768540
Remove plugin and add rule
huong-li-nguyen Nov 28, 2024
c4324e7
Remove plugin
huong-li-nguyen Nov 28, 2024
17fb2dd
Merge branch 'main' into tidy/test-stylelint-plugin
huong-li-nguyen Nov 28, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .stylelintrc
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
"color-function-notation": "legacy",
"alpha-value-notation": "number",
"color-hex-length": "long",
"selector-not-notation": null
"selector-not-notation": null,
"declaration-property-value-no-unknown": true
}
}
6 changes: 3 additions & 3 deletions vizro-ai/examples/dashboard_ui/assets/custom.css
Original file line number Diff line number Diff line change
Expand Up @@ -188,15 +188,15 @@
background-color: inherit;
color: var(--text-primary);
height: 2rem;
scale: 90%;
transform: scale(0.9);
}

.dropdown-menu-toggle-class:hover {
background-color: inherit;
color: var(--text-primary);
cursor: pointer;
height: 2rem;
scale: 90%;
transform: scale(0.9);
}

.dropdown-menu-toggle-class.btn-primary:focus:not(
Expand Down Expand Up @@ -333,7 +333,7 @@ img#banner {
flex-flow: column wrap;
gap: 12px;
justify-content: flex-start;
overflow: hidden; /* to check */
overflow: hidden; /* check and remove comment */
Copy link
Contributor Author

@huong-li-nguyen huong-li-nguyen Nov 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nadijagraca - these 3 CSS properties were flagged by the linter. When you update the vizro-ai demo, could you please double-check whether these changes are okay to be made? :)

}

.flex-container h4 {
Expand Down
Loading