-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tidy] Add stylelint rule to flag unmatched CSS properties #898
Merged
Merged
Changes from all commits
Commits
Show all changes
68 commits
Select commit
Hold shift + click to select a range
81eeb60
Add changes
huong-li-nguyen 5f0e020
Update latest CSS file
huong-li-nguyen fff42a1
Remove CSS for tooltip
huong-li-nguyen 07d8929
Update vizro-bootstrap.min.css
huong-li-nguyen 0a7ff33
Create 20241119_155853_huong_li_nguyen_add_bs_tooltip_styling.md
huong-li-nguyen 7abbbbf
Merge branch 'main' into tidy/add-bs-tooltip-styling
huong-li-nguyen 480914d
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 4a598a2
Remove all CSS variables
huong-li-nguyen 39032be
Rename variables with vizro-bs equivalent
huong-li-nguyen 1ca73f8
Replace with rem units
huong-li-nguyen 610a188
Hardcode values where suitable
huong-li-nguyen 96464d6
Add back selected variables
huong-li-nguyen e35fe36
Replace matched values
huong-li-nguyen 3404355
Replace remaining values
huong-li-nguyen 4d07ec0
Create 20241119_173819_huong_li_nguyen_remove_variables.md
huong-li-nguyen 5a47f97
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] e7cdc9b
Merge branch 'tidy/add-bs-tooltip-styling' into tidy/remove-variables
huong-li-nguyen 1277f11
Merge branch 'tidy/remove-variables' of https://github.com/mckinsey/v…
huong-li-nguyen b52fb72
Fix collapse bg color
huong-li-nguyen 42bdb3a
Update color
huong-li-nguyen 0742dc8
Fix renaming of border
huong-li-nguyen ba273f7
Replace remaining variable mentions
huong-li-nguyen 307ce5c
Merge branch 'main' into tidy/remove-variables
huong-li-nguyen 84d5d73
Update CSS variables outside of static folder
huong-li-nguyen 2ec7c6e
Revert demo changes
huong-li-nguyen 9ff9e3d
Update CSS variables
huong-li-nguyen 4fac651
Update changelog
huong-li-nguyen c77fd12
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] f09f7b6
Update vizro version
huong-li-nguyen 0065779
Update requirements
huong-li-nguyen 5d1034d
Add requirements for `dev`
huong-li-nguyen 28ae503
Add banner
huong-li-nguyen dc498ef
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] f9bba27
Update table
huong-li-nguyen bf90f2c
Merge branch 'main' into tidy/remove-variables
huong-li-nguyen e0c9f20
Fix tabs
huong-li-nguyen 96fcd96
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] f8ab934
Rename file
huong-li-nguyen 5e7b3b1
Merge branch 'tidy/remove-variables' into demo/update-css-variables
huong-li-nguyen 4431186
Fix dashboard-ui
huong-li-nguyen 73c55c5
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 4600223
Merge branch 'main' into tidy/remove-variables
huong-li-nguyen de7781e
Clarify comment
huong-li-nguyen 7b3e2e3
Add comment
huong-li-nguyen 34a74e3
Merge branch 'tidy/remove-variables' into demo/update-css-variables
huong-li-nguyen 9358742
Update docs
huong-li-nguyen e9be97e
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] c18f942
Lint
huong-li-nguyen a9dd04d
Merge branch 'tidy/remove-variables' of https://github.com/mckinsey/v…
huong-li-nguyen 06f93df
Merge branch 'tidy/remove-variables' into demo/update-css-variables
huong-li-nguyen 26046be
Update
huong-li-nguyen bf1a006
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] aaf36a3
Fix typo
huong-li-nguyen d6c2aaf
Merge branch 'tidy/remove-variables' into demo/update-css-variables
huong-li-nguyen bbff0a4
Merge branch 'main' into demo/update-css-variables
huong-li-nguyen 06ceaed
Merge branch 'main' into demo/update-css-variables
huong-li-nguyen f2af917
Update assets folder for dev
huong-li-nguyen 15d6e6e
Fix integration tests
huong-li-nguyen 9811a82
Add plugin
huong-li-nguyen 7b88c56
Fix remaining unmatched properties
huong-li-nguyen e2ce378
Tidy
huong-li-nguyen 32a9043
Merge branch 'demo/update-css-variables' into tidy/test-stylelint-plugin
huong-li-nguyen 2f62d11
Update custom.css
huong-li-nguyen c1dd4b7
Merge branch 'main' into tidy/test-stylelint-plugin
huong-li-nguyen db66e4f
Merge branch 'main' into tidy/test-stylelint-plugin
huong-li-nguyen 6768540
Remove plugin and add rule
huong-li-nguyen c4324e7
Remove plugin
huong-li-nguyen 17fb2dd
Merge branch 'main' into tidy/test-stylelint-plugin
huong-li-nguyen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nadijagraca - these 3 CSS properties were flagged by the linter. When you update the vizro-ai demo, could you please double-check whether these changes are okay to be made? :)