Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tidy] Add stylelint rule to flag unmatched CSS properties #898

Merged
merged 68 commits into from
Nov 28, 2024

Conversation

huong-li-nguyen
Copy link
Contributor

@huong-li-nguyen huong-li-nguyen commented Nov 27, 2024

Description

Screenshot

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

    • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
    • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
    • I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.
    • I have not referenced individuals, products or companies in any commits, directly or indirectly.
    • I have not added data or restricted code in any commits, directly or indirectly.

huong-li-nguyen and others added 30 commits November 18, 2024 13:00
@github-actions github-actions bot added the Vizro-AI 🤖 Issue/PR that addresses Vizro-AI package label Nov 27, 2024
Copy link
Contributor

github-actions bot commented Nov 27, 2024

View the example dashboards of the current commit live on PyCafe ☕ 🚀

Updated on: 2024-11-28 13:41:46 UTC
Commit: c4324e7

Link: vizro-core/examples/dev/

Link: vizro-core/examples/scratch_dev

Link: vizro-core/examples/visual-vocabulary/

Link: vizro-ai/examples/dashboard_ui/

@huong-li-nguyen huong-li-nguyen changed the base branch from main to demo/update-css-variables November 27, 2024 09:01
Base automatically changed from demo/update-css-variables to main November 27, 2024 10:17
@@ -333,7 +333,7 @@ img#banner {
flex-flow: column wrap;
gap: 12px;
justify-content: flex-start;
overflow: hidden; /* to check */
overflow: hidden; /* check and remove comment */
Copy link
Contributor Author

@huong-li-nguyen huong-li-nguyen Nov 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nadijagraca - these 3 CSS properties were flagged by the linter. When you update the vizro-ai demo, could you please double-check whether these changes are okay to be made? :)

@huong-li-nguyen huong-li-nguyen changed the title Tidy/test stylelint plugin [Tidy] Add stylelint plugin to flag unmatched CSS properties Nov 27, 2024
@huong-li-nguyen huong-li-nguyen changed the title [Tidy] Add stylelint plugin to flag unmatched CSS properties [Tidy] Add stylelint rule to flag unmatched CSS properties Nov 28, 2024
@huong-li-nguyen huong-li-nguyen merged commit 736294c into main Nov 28, 2024
29 of 35 checks passed
@huong-li-nguyen huong-li-nguyen deleted the tidy/test-stylelint-plugin branch November 28, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Vizro-AI 🤖 Issue/PR that addresses Vizro-AI package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants