[Tidy] Prepare for dynamic filters, part 1 of 2

[antonymilne]

Description

Refactor filter.py to prepare for dynamic filters. This solves several long-standing TODOs in this file.

• data loading has been isolated to a single place rather than repeated. This improves performance during pre_build (useful but not critical) and when updating filters during dashboard runtime (not yet implemented, but performance here is critical)
• _set methods all rewritten and simplified (no more loops needed)
• isolated methods that will be required during runtime - these are now called in __call__ (not yet used anywhere but will be soon)
• validation is slightly improved to handle some cases we didn't handle before - see the new tests to understand what these are
• the newly introduced TODOs will be short-term ones and will go once we've finished implementing dynamic filters

@petar-qb I recommend reviewing as follows:

• look at commits 9449c73 and b37f38f
• read through the whole filter.py file as it now stands
• do some manual testing

Still TODO:

• write tests

Screenshot

Notice

• I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

  • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
  • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
  • I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.
  • I have not referenced individuals, products or companies in any commits, directly or indirectly.
  • I have not added data or restricted code in any commits, directly or indirectly.

[github-actions]

View the example dashboards of the current commit live on PyCafe ☕ 🚀

Updated on: 2024-11-07 11:55:22 UTC
Commit: 69cc36d

Link: vizro-core/examples/dev/

Link: vizro-core/examples/scratch_dev

Link: vizro-core/examples/visual-vocabulary/

Link: vizro-ai/examples/dashboard_ui/

[maxschulz-COL]

Do you guys want any further reviews?

[antonymilne]

Do you guys want any further reviews?

Let's say @petar-qb is the lead reviewer but a quick second pair of eyes would be good thank you!

[petar-qb]

This is the ground breaking refactoring that will and optimise and facilitate the implementation of the dynamic filters!!

The targeted_data format is just the master piece 🎨

I left a few minor comments, but other than that, all good! (tests are also okay, so no comments for that part)

[maxschulz-COL]

As promised, glanced over it and it looks good to me