[POC] Feat/update filter options actions #554
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonymilne
commented
Jun 27, 2024
| } | ||
| } | ||
| ) | ||
| figures_outputs[filter.id] = filter.build() |
There was a problem hiding this comment.
Will currently be nesting infinitely?
There was a problem hiding this comment.
Need general "rebuild" action that calls pre_build again and then replaces whole build?
antonymilne
commented
Jun 27, 2024
Comment on lines
+43
to
+49
| filter._set_categorical_selectors_options( | ||
| force_update=True, | ||
| data_load_kwargs={ | ||
| target_id: { | ||
| "points": ctx.args_grouping["external"]["parameters"][0]["value"] | ||
| } | ||
| } |
There was a problem hiding this comment.
This is pre_build in general
antonymilne
commented
Jun 27, 2024
| targets=target_ids, | ||
| ctds_filter=ctx.args_grouping["external"]["filters"], | ||
| ctds_filter_interaction=ctx.args_grouping["external"]["filter_interaction"], | ||
| ctds_parameters=ctx.args_grouping["external"]["parameters"], | ||
| ) | ||
|
|
There was a problem hiding this comment.
Also need to handle case of no parameter, which means adding more complexity here. Need to reload all relevant dataframes and effectively treat filter like a figure.
Should controls be treated like figures too? e.g. how to enable filter_interaction to update filter in control panel?
|
Superseded by #850 and following PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Screenshot
Notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":