Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#379] Make use of Python3.11 #380

Merged
merged 3 commits into from
Jul 1, 2024
Merged

Conversation

alextreme
Copy link
Member

@alextreme alextreme commented Mar 21, 2024

fixes #379 (Objects API part)

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.84%. Comparing base (8440964) to head (22a8412).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #380   +/-   ##
=======================================
  Coverage   94.84%   94.84%           
=======================================
  Files         135      135           
  Lines        4657     4657           
=======================================
  Hits         4417     4417           
  Misses        240      240           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alextreme alextreme requested a review from annashamray March 21, 2024 17:41
Copy link
Collaborator

@annashamray annashamray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's discuss in the refinement? I think strange to approve it while Objecttypes still doesn't support Django4.2 yet

Afaik the first prio is to switch to django4.2 for Objecttypes, ON and OZ
And we also started switching to open-api-framework
Should we make some epic with some roadmap to upgrade\patch all APIs ?

@alextreme
Copy link
Member Author

Makes sense, this was just because I'm running Py3.11 locally but ideally it should be done together with Django4.2

@annashamray annashamray force-pushed the issue/379-use-python311 branch from ced51b8 to a7f3b22 Compare June 21, 2024 14:00
@annashamray annashamray requested a review from stevenbal June 21, 2024 14:19
@annashamray
Copy link
Collaborator

annashamray commented Jun 21, 2024

@alextreme I think the time has come :)

@annashamray annashamray merged commit e0e6ff8 into master Jul 1, 2024
11 checks passed
@annashamray annashamray deleted the issue/379-use-python311 branch July 1, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Python3.11
4 participants