Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#381] Improve admin search to also search through object data #382

Merged
merged 1 commit into from
Apr 29, 2024
Merged

[#381] Improve admin search to also search through object data #382

merged 1 commit into from
Apr 29, 2024

Conversation

alextreme
Copy link
Member

No description provided.

@alextreme alextreme requested a review from annashamray March 21, 2024 17:41
annashamray
annashamray approved these changes Apr 8, 2024
View reviewed changes
Copy link
Collaborator

@annashamray annashamray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve but does it really work with JSON fields?

@alextreme
Copy link
Member Author

Yes, I actually tried this out myself (reason of PR #380 ) because I also couldn't believe it would be this easy.

https://docs.djangoproject.com/en/5.0/topics/db/queries/#querying-jsonfield

@annashamray annashamray merged commit b35c2a3 into master Apr 29, 2024
8 checks passed
@annashamray annashamray deleted the issue/381-search-through-data branch April 29, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annashamray annashamray annashamray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alextreme @annashamray