[#31] Bypass validation of defaults for Django fields containing choices #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swrichards
force-pushed
the
31-literal-default-values
branch
2 times, most recently
from
d210fc0 to
8f310c4
Compare
The reason here is that the source of our config values cannot express complex types such as enum members, and that defaults for Django fields with choices frequently include such types (or callables returning such types). We are mainly about the types of the values provided from outside, not of Django field defaults (beyond null and blank), so we can leave the validation of the default to Django.
swrichards
force-pushed
the
31-literal-default-values
branch
from
8f310c4 to
fab1ad8
Compare
stevenbal
reviewed
Dec 17, 2024
Comment on lines
+28
to
+29
| str_with_choices_and_incorrectly_typed_default = models.CharField( | ||
| max_length=3, choices=StrChoices.choices, default=1974 |
There was a problem hiding this comment.
Is it intentional that this is a CharField with an int default?
There was a problem hiding this comment.
Indeed, that's because the test has to validate that the default is not validated (I hope the name will provide sufficient hint that this was not an oversight).
stevenbal
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason here is that the source of our config values cannot
express complex types such as enum members, and that defaults
for Django fields with choices frequently include such types
(or callables returning such types). We are mainly about the
types of the values provided from outside, not of Django field
defaults (beyond null and blank), so we can leave the validation
of the default to Django.