Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default values for choices should be converted to literals #31

Closed
swrichards opened this issue Dec 13, 2024 · 0 comments · Fixed by #36
Closed

Default values for choices should be converted to literals #31

swrichards opened this issue Dec 13, 2024 · 0 comments · Fixed by #36

Comments

@swrichards
Copy link
Contributor

See #27 (comment) -- although we now convert choices to literal types, the default value is still a Choices object (or similar), which does not validate as a literal value.
This was referenced Dec 13, 2024
Merged
Closed
swrichards added a commit that referenced this issue Dec 17, 2024
@swrichards
[#31] Do not validate defaults for Django fields with choices
3be3413
swrichards added a commit that referenced this issue Dec 17, 2024
@swrichards
[#31] Do not validate defaults for Django fields with choices
7f4f628 
The reason here is that the source of our config values cannot
express complex types such as enum members, and that defaults
for Django fields with choices frequently include such types
(or callables returning such types). We are mainly about the
types of the values provided from outside, not of Django field
defaults (beyond null and blank), so we can leave the validation
of the default to Django.
@swrichards swrichards linked a pull request Dec 17, 2024 that will close this issue
[#31] Bypass validation of defaults for Django fields containing choices #36
Merged
swrichards added a commit that referenced this issue Dec 17, 2024
@swrichards
[#31] Do not validate defaults for Django fields with choices
d210fc0 
The reason here is that the source of our config values cannot
express complex types such as enum members, and that defaults
for Django fields with choices frequently include such types
(or callables returning such types). We are mainly about the
types of the values provided from outside, not of Django field
defaults (beyond null and blank), so we can leave the validation
of the default to Django.
swrichards added a commit that referenced this issue Dec 17, 2024
@swrichards
[#31] Do not validate defaults for Django fields with choices
8f310c4 
The reason here is that the source of our config values cannot
express complex types such as enum members, and that defaults
for Django fields with choices frequently include such types
(or callables returning such types). We are mainly about the
types of the values provided from outside, not of Django field
defaults (beyond null and blank), so we can leave the validation
of the default to Django.
swrichards added a commit that referenced this issue Dec 17, 2024
@swrichards
[#31] Do not validate defaults for Django fields with choices
fab1ad8 
The reason here is that the source of our config values cannot
express complex types such as enum members, and that defaults
for Django fields with choices frequently include such types
(or callables returning such types). We are mainly about the
types of the values provided from outside, not of Django field
defaults (beyond null and blank), so we can leave the validation
of the default to Django.
swrichards added a commit that referenced this issue Dec 17, 2024
@swrichards
Merge pull request #36 from maykinmedia/31-literal-default-values
751557a 
[#31] Bypass validation of defaults for Django fields containing choices
swrichards added a commit that referenced this issue Dec 19, 2024
@swrichards
[#31] Accept Path objects for YAML files
80ba04d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@swrichards