♻️ - refactor: refactor Kanban api #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenvandescheur
force-pushed
the
issue/kanban-api
branch
from
05f18cd to
6d6cba5
Compare
svenvandescheur
force-pushed
the
issue/kanban-api
branch
from
6d6cba5 to
0b12d32
Compare
SilviaAmAm
approved these changes
Jun 4, 2024
Xaohs
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts quite some code kanban code back to before the "componentList" change so that the API remains largely unchanged since the previous release (the changes made to the API were larger than I expected).
As a side effect: certain features / callbacks might be removed however; I think they ware redundant since
onObjectListsChangeshould provide the information to deal with dragging, we can expand the functionality later if we need to.The actual requirement (support a custom component in the kanban) is kept. It's now optional and the component can be passed using the fieldset(s).