Chore/refactor landing #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SilviaAmAm
reviewed
Jun 4, 2024
| title: list.name, | ||
| days: timeAgo(list.created), | ||
| assigneeNames: constructAssigneeNames(list.assignees), | ||
| href: `/destruction-list/${list.name}`, |
There was a problem hiding this comment.
Do we want to use the name here? In the detail view I had used the pk, but we should maybe add uuids to the destruction list model and then use those 🤔
There was a problem hiding this comment.
Should be the PK/uuid indeed but the detail view is missing in main? What do you prefer, pk or uuid?
There was a problem hiding this comment.
Indeed: it is still a PR: #54
We can make it pk for now, and once we have uuids, use those?
Xaohs
approved these changes
Jun 4, 2024
svenvandescheur
force-pushed
the
chore/refactor-landing
branch
from
bf1519a to
18e8db0
Compare
SilviaAmAm
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires: maykinmedia/admin-ui#75 to me merged and released.