[MM-58805]: Remove Standalone code part - 1 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rajat-Dabade
commented
Jun 28, 2024
| @@ -154,6 +154,14 @@ endif | |||
|
|
|||
| @echo plugin built at: dist/$(BUNDLE_NAME) | |||
|
|
|||
| info: ## Display build information | |||
There was a problem hiding this comment.
This was only added for debugging purposes. Will remove this after the plugin becomes stable.
Created the issue to track this down: #3
Rajat-Dabade
changed the title
Rajat-Dabade
added
2: Dev Review
harshilsharma63
requested changes
Jul 5, 2024
sbishel
approved these changes
Jul 9, 2024
* refactor: removed the mattermost auth check * refactor: removed standalone sql part of code * refactor: removed not required function from store level * refactor: removed session check for plugin * refactor: removed the unnecessary test * refactor: removed MattermostAuth * Deperate isPlugin and isSingleUser part - 2 (#5) * removed remaining singleUser and isPlugin code * chore: linter fixes
* fix: webapp test cases * refactor: added rules to makefile and added github workflow for testing * chore: added ci github workflow * chore: updated github flow for ci and typos * chore: typefix * refactor: added rule to install golangci lint * chore: to trigger action * fix: error in ci.yml * refactor: updated rule * refactor: fix linter issue
marianunez
approved these changes
Jul 16, 2024
* refactor: get rid of mattermost auth layer * chore: removed removeDuplicate from isboardsFromRow * refactor: changed method to private' * refactor: private method calls private method * refactor: get license from server API
* refactor: updated workflow and Readme * chore: added Contributing and security.md * refactor: updated README and makefile with new release process * refactor: updated the protected branch name * refactor: readme * refactor: updated README * refactor: removed focalboard references * refactor: updated README
* refactor: changed name for generating tar * refactor: changed from board to boards * refactor: changed the folder name from board to boards
Rajat-Dabade
removed
the
Do Not Merge/Awaiting PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR mainly focus on removing standalone code which include