Deprecate standalone SQL store level #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rajat-Dabade
added
2: Dev Review
harshilsharma63
requested changes
Jul 5, 2024
| @@ -234,36 +234,6 @@ func (s *SQLStore) getBoard(db sq.BaseRunner, boardID string) (*model.Board, err | |||
| return s.getBoardByCondition(db, sq.Eq{"id": boardID}) | |||
| } | |||
|
|
|||
| func (s *SQLStore) getBoardsForUserAndTeam(db sq.BaseRunner, userID, teamID string, includePublicBoards bool) ([]*model.Board, error) { | |||
There was a problem hiding this comment.
Once this is removed, we can get rid of the mattermostauthlayer dir by bring its code over here. Up to you if you wanna handle that in this PR or create a separate PR for it. If handling in a separate PR, can you please create a Jira ticket to track it?
There was a problem hiding this comment.
I will take care of this in subsequent PR.
Created a ticket for this: https://mattermost.atlassian.net/browse/MM-59349
| @@ -47,12 +48,12 @@ func (s *SQLStore) AddUpdateCategoryBoard(userID string, categoryID string, boar | |||
| } | |||
|
|
|||
| func (s *SQLStore) CanSeeUser(seerID string, seenID string) (bool, error) { | |||
There was a problem hiding this comment.
Why not delete this function as its implemented in mattermostauthlayer?
There was a problem hiding this comment.
This required more cleaner, will do this as a part of this ticket: https://mattermost.atlassian.net/browse/MM-59349
harshilsharma63
approved these changes
Jul 9, 2024
Rajat-Dabade
changed the title
sbishel
approved these changes
Jul 9, 2024
Rajat-Dabade
commented
Jul 10, 2024
* removed remaining singleUser and isPlugin code * chore: linter fixes
Rajat-Dabade
added a commit
that referenced
this pull request
Jul 30, 2024
* refactor: isPlugin for API level * chore: removed GetContextConn as it is not required * chore: clean up api.go removed none required function * chore: removed commented code * refactor: removed the admin as its no log required * refactor: removed handlePostTeamRegenerateSignupToken as not used anymore * refactor: updated make file rules * refactor: removed isGuest code * refactor: removed auth login password changepassword code * chore: linter fixes * refactor: removed user login register code * chore: linter fixes * refactor: removed auth layer * refactor: removed isSingle user checks * chore: removed debugging logs * chore: removed debugging logs * revert: isGuestUser check * Deprecate standalone SQL store level (#4) * refactor: removed the mattermost auth check * refactor: removed standalone sql part of code * refactor: removed not required function from store level * refactor: removed session check for plugin * refactor: removed the unnecessary test * refactor: removed MattermostAuth * Deperate isPlugin and isSingleUser part - 2 (#5) * removed remaining singleUser and isPlugin code * chore: linter fixes * MM-59356: Fixing testcase for webapp and server (#6) * fix: webapp test cases * refactor: added rules to makefile and added github workflow for testing * chore: added ci github workflow * chore: updated github flow for ci and typos * chore: typefix * refactor: added rule to install golangci lint * chore: to trigger action * fix: error in ci.yml * refactor: updated rule * refactor: fix linter issue * [MM-59349]: Getting Rid of Mattermost Auth layer (#10) * refactor: get rid of mattermost auth layer * chore: removed removeDuplicate from isboardsFromRow * refactor: changed method to private' * refactor: private method calls private method * refactor: get license from server API * [MM-59824]: Removed website code. (#12) * MM-59294: Workflow updated and release process (#7) * refactor: updated workflow and Readme * chore: added Contributing and security.md * refactor: updated README and makefile with new release process * refactor: updated the protected branch name * refactor: readme * refactor: updated README * refactor: removed focalboard references * refactor: updated README * From `focalboard` to `board` to generate tar bundle (#14) * refactor: changed name for generating tar * refactor: changed from board to boards * refactor: changed the folder name from board to boards * fix: ci issue * chore: ci fix * chore: ci fix * minor fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to eliminate database interaction code for standalone and single-user applications.
Stack on: #2