-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update developer-setup.md to provide no-docker setup #1351
Conversation
Hello @sinansonmez, Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @sinansonmez. Provided editorial feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you make those changes, could you move those steps to a separate section at the bottom of the doc and change that "Install Docker" step to point the user to the new section if they don't want to use Docker? I think we should split those steps into their own section because I think people will miss that those steps are optional and go through them after installing Docker. I want to keep the main instructions simpler because I screw up complicated instructions all the time 😅
Co-authored-by: Carrie Warner (Mattermost) <[email protected]>
Co-authored-by: Carrie Warner (Mattermost) <[email protected]>
Co-authored-by: Carrie Warner (Mattermost) <[email protected]>
Co-authored-by: Carrie Warner (Mattermost) <[email protected]>
Co-authored-by: Carrie Warner (Mattermost) <[email protected]>
@hmhealey @cwarnermm Thanks for the feedback. Unfortunately, it is not clear to me how to proceed. Currently there are 3 main sections
Under |
Hi @sinansonmez! The ask is to separate the Docker steps within their own section (at the top of the page as the primary way forward) from the not-using-Docker steps you're providing. @hmhealey is suggesting we move the non-Docker info to its own section elsewhere on the page to avoid reader confusion. The reader's experience would look like this:
Meanwhile, following the Setup the Mattermost Server section, there's a new section about setting up Mattermost Server without Docker. That's where your steps would live. |
Yep, that's right. So with your steps, there'd be 4 sections:
|
thanks for the explanation @hmhealey @cwarnermm the page is updated as requested |
Newest code from cwarnermm has been published to preview environment for Git SHA 0fe22c7 |
2 similar comments
Newest code from cwarnermm has been published to preview environment for Git SHA 0fe22c7 |
Newest code from cwarnermm has been published to preview environment for Git SHA 0fe22c7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @sinansonmez!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Sinan!
Summary
Update developer-setup.md to provide no-docker setup information