Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix indents in "Set up your development environment" #1386

Merged
merged 3 commits into from
Jul 10, 2024
Merged

Fix indents in "Set up your development environment" #1386

merged 3 commits into from
Jul 10, 2024

Conversation

tnir
Copy link
Contributor

@tnir tnir commented Jun 28, 2024 •
edited
Loading

@mattermost-build
Copy link
Contributor

Hello @tnir,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@cwarnermm cwarnermm self-requested a review June 28, 2024 23:42
@cwarnermm cwarnermm added the 2: Editor Review Requires review by an editor label Jun 28, 2024
@mattermost-build
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

@tnir
Copy link
Contributor Author

tnir commented Jul 9, 2024

@cwarnermm Updates?

@cwarnermm cwarnermm added preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories and removed Lifecycle/1:stale labels Jul 9, 2024
@cwarnermm cwarnermm added preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories and removed preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories labels Jul 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024

Newest code from cwarnermm has been published to preview environment for Git SHA daa062a

cwarnermm
cwarnermm approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@cwarnermm cwarnermm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @tnir!

@cwarnermm cwarnermm added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Editor Review Requires review by an editor preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories labels Jul 9, 2024
@cwarnermm cwarnermm requested a review from amyblais July 9, 2024 20:17
@amyblais amyblais merged commit a47fef0 into mattermost:master Jul 10, 2024
4 checks passed
@tnir tnir deleted the tn-fix-indents-on-dev-setup branch July 10, 2024 14:27
@github-actions GitHub Actions
Copy link

Newest code from cwarnermm has been published to preview environment for Git SHA 5ac964c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwarnermm cwarnermm cwarnermm approved these changes

@amyblais amyblais amyblais approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tnir @mattermost-build @amyblais @cwarnermm