fix: add retry and check using new sdk method for finalization #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dutterbutter
commented
Oct 29, 2024
Comment on lines
+125
to
+130
|
|
||
| // Check if the batch has been processed before attempting finalization | ||
| const l1BatchNumber = finalizeWithdrawalParams.value?.l1BatchNumber; | ||
| if (l1BatchNumber && !(await isBatchProcessed(l1BatchNumber))) { | ||
| throw new Error("Batch not yet processed. Please wait and try again later."); | ||
| } |
There was a problem hiding this comment.
This does not seem necessary as it doesnt seem to be the root of the issue. Wallet.isWithdrawalFinalized() is used already and provides that check for withdrawal finalization
dutterbutter
commented
Oct 29, 2024
Comment on lines
+180
to
+191
| const isBatchProcessed = async (batchNumber: any) => { | ||
| const providerStore = useZkSyncProviderStore(); | ||
| try { | ||
| const totalBatchesExecuted = await providerStore.requestProvider().getTotalBatchesExecuted(); | ||
|
|
||
| return batchNumber <= BigNumber.from(totalBatchesExecuted).toNumber(); | ||
| } catch (error) { | ||
| // eslint-disable-next-line no-console | ||
| console.error("Error fetching total batches executed:", error); | ||
| return false; | ||
| } | ||
| }; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial work to resolve #193