Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds getter function to provider class for retrieving total executed batches #208

Closed
wants to merge 2 commits into from

Conversation

dutterbutter
Copy link

What 💻

  • First thing updated with this PR
  • Second thing updated with this PR
  • Third thing updated with this PR

Why ✋

  • Reason why first thing was added to PR
  • Reason why second thing was added to PR
  • Reason why third thing was added to PR

Evidence 📷

Include screenshots, screen recordings, or console output here demonstrating that your changes work as intended

Notes 📝

  • Any notes/thoughts that the reviewers should know prior to reviewing the code?

@petarTxFusion
Copy link
Contributor

Hey Dustin, we can keep it like this and if you can just give us the heads up before it can be merged so that we can prepare other SDKs

@dutterbutter
Copy link
Author

Thanks @petarTxFusion ! Still unsure if this change is useful or not. I have the ethers v6 version here fyi.

@petarTxFusion
Copy link
Contributor

petarTxFusion commented Oct 11, 2024

Then we should wait and discuss it since it could be troubling if we endup needing to remove it and result in breaking change. The code looks fine only tests are missing but we can add that if we decide to merge it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants