Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui): Rename TimelineEnd to TimelineNewItemPosition #4328

Merged
merged 1 commit into from
Nov 26, 2024

Commits on Nov 26, 2024

  1. chore(ui): Rename TimelineEnd to TimelineNewItemPosition.

    This patch renames `TimelineEnd` into `TimelineNewItemPosition` for
    2 reasons:
    
    1. In the following patches, we will introduce a new variant to insert
       at a specific index, so the suffix `End` would no longer make sense.
    
    2. It's exactly like `TimelineItemPosition` except that it's used
       only and strictly only to add **new** items, which is why we can't use
       `TimelineItemPosition` because it contains the `UpdateDecrypted`
       variant. This renaming reflects it's only about **new** items.
    
    This patch takes the opportunity to move the `RemoteEventOrigin` inside
    `TimelineNewItemPosition` to simplify method signatures. They always
    go together.
    Hywan committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    49f88c2 View commit details
    Browse the repository at this point in the history