chore(ui): Rename TimelineEnd to TimelineNewItemPosition
#4328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch renames `TimelineEnd` into `TimelineNewItemPosition` for 2 reasons: 1. In the following patches, we will introduce a new variant to insert at a specific index, so the suffix `End` would no longer make sense. 2. It's exactly like `TimelineItemPosition` except that it's used only and strictly only to add **new** items, which is why we can't use `TimelineItemPosition` because it contains the `UpdateDecrypted` variant. This renaming reflects it's only about **new** items. This patch takes the opportunity to move the `RemoteEventOrigin` inside `TimelineNewItemPosition` to simplify method signatures. They always go together.
Hywan
force-pushed
the
chore-ui-timeline-end-renaming
branch
from
c8a341f
to
49f88c2
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4328 +/- ##
==========================================
+ Coverage 85.05% 85.09% +0.03%
==========================================
Files 275 275
Lines 30309 30307 -2
==========================================
+ Hits 25780 25789 +9
+ Misses 4529 4518 -11 ☔ View full report in Codecov by Sentry. |
poljar
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Extracted from #3512)
This patch renames
TimelineEndintoTimelineNewItemPositionfor 2 reasons:In the following patches, we will introduce a new variant to insert at a specific index, so the suffix
Endwould no longer make sense.It's exactly like
TimelineItemPositionexcept that it's used only and strictly only to add new items, which is why we can't useTimelineItemPositionbecause it contains theUpdateDecryptedvariant. This renaming reflects it's only about new items.This patch takes the opportunity to move the
RemoteEventOrigininsideTimelineNewItemPositionto simplify method signatures. They always go together.EventCachestorage #3280