Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warning when exclusively deprecated SRV records are in use #38

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add warning when exclusively deprecated SRV records are in use #38

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,12 @@ let App = create({
</div>
)
}
if (typeof json.DNSResult.SRVCName === "string" && !json.DNSResult.SRVCName.startsWith("_matrix-fed.")) {
tldr.push(<div className="warning" key={`srv-deprecated-${tldr.length}`}>
WARN: Deprecated SRV record <code>_matrix</code> in use. Please
add an additional SRV record to cover <code>_matrix-fed</code> too.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we can have a link to something that explains what this is?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where would that live?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good question, maybe the spec would be a bit hardcore but it feels like it'd be generous to have something.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

those were my thoughts, fwiw. The spec generally doesn't feel like the correct place, and it's not like this is server-specific. Possibly something on the matrix.org site, but where remains a question.

I'm somewhat hopeful that if someone got as far as the federation tester and is seeing this message then they are aware of what an SRV record is. Hopefully, they only ever see this warning if their homeserver documentation didn't tell them to set up the correct thing (ie: Synapse's docs need updating).

</div>)
}
this.setState({
json: json,
tldr: tldr,
Expand Down