Add warning when exclusively deprecated SRV records are in use #38
Conversation
| if (typeof json.DNSResult.SRVCName === "string" && !json.DNSResult.SRVCName.startsWith("_matrix-fed.")) { | ||
| tldr.push(<div className="warning" key={`srv-deprecated-${tldr.length}`}> | ||
| WARN: Deprecated SRV record <code>_matrix</code> in use. Please | ||
| add an additional SRV record to cover <code>_matrix-fed</code> too. |
There was a problem hiding this comment.
maybe we can have a link to something that explains what this is?
There was a problem hiding this comment.
Where would that live?
There was a problem hiding this comment.
It's a good question, maybe the spec would be a bit hardcore but it feels like it'd be generous to have something.
There was a problem hiding this comment.
those were my thoughts, fwiw. The spec generally doesn't feel like the correct place, and it's not like this is server-specific. Possibly something on the matrix.org site, but where remains a question.
I'm somewhat hopeful that if someone got as far as the federation tester and is seeing this message then they are aware of what an SRV record is. Hopefully, they only ever see this warning if their homeserver documentation didn't tell them to set up the correct thing (ie: Synapse's docs need updating).
Paired with matrix-org/matrix-federation-tester#142
Domain tests:
3c.s.resolvematrix.dev-_matrixonly,.well-known4.s.resolvematrix.dev-_matrixonly3c.msc4040.s.resolvematrix.dev-_matrix-fedonly,.well-known4.msc4040.s.resolvematrix.dev-_matrix-fedonlyt2l.io-_matrix-fedand_matrixfallback(TODO: Update resolvematrix.dev to support this case)