Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes #255

Merged
merged 3 commits into from
Oct 16, 2024
Merged

Minor fixes #255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d510adb
build(deps): bump cookie and express
dependabot[bot] Oct 13, 2024
65504b8
chg: small fixes to guides / remove unused function
marcello33 Oct 16, 2024
38974f0
Merge branch 'dependabot/npm_and_yarn/multi-9f37c16f8f' into mardizzo…
marcello33 Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,6 @@ To use the `express-cli` you have to execute the following steps.
- `VERBOSE=true` prints logs from the remote machines. If set to `false`, only `express-cli` and `matic-cli` logs will
be shown

In case you plan to utilize express-cli for Google Cloud, you will need to make few modifications like SSH keys. It's important to note that express-cli is not fully tested yet on GCP, and not all features are accessible. Check the [GCP dev guide](./docs/gcp_dev_guide.md).

### Auth Configuration

As a prerequisite, you need to configure authentication on `aws`
Expand Down
2 changes: 1 addition & 1 deletion docs/gcp_dev_guide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ ssh-keygen -f ~/ubuntu.pem -N ""
- If you don't have a keypair, run the following command to generate an SSH key pair: `ssh-keygen -f ubuntu.pem -N ""`
- The above command generates two files. _ubuntu.pem_ (private keyfile) and _ubuntu.pem.pub_ (public key)
- These two files have to be updated in _.env_ file.
- Locate the `TF_VAR_GCE_PUB_KEY_FILE` variable in .env file and set its value to the absolute path pointing to the public key file you generated.
- Locate the `TF_VAR_GCP_PUB_KEY_FILE` variable in .env file and set its value to the absolute path pointing to the public key file you generated.
- Locate the `PEM_FILE_PATH` variable in .env file and set its value to the absolute path pointing to the private key file you generated.

## Resource Naming Convention
Expand Down
Loading
Loading