Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fixes #255

Merged
merged 3 commits into from
Oct 16, 2024
Merged

Minor fixes #255

merged 3 commits into from
Oct 16, 2024

Conversation

marcello33
Copy link
Contributor

Description

Minor fixes to docs, deletion of an unused function and bump some deps.

Changes

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • New test case for remote devnet

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

Testing

  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai or amoy

dependabot bot and others added 3 commits October 13, 2024 07:34
@dependabot
build(deps): bump cookie and express
d510adb 
Bumps [cookie](https://github.com/jshttp/cookie) and [express](https://github.com/expressjs/express). These dependencies needed to be updated together.

Updates `cookie` from 0.6.0 to 0.7.1
- [Release notes](https://github.com/jshttp/cookie/releases)
- [Commits](jshttp/cookie@v0.6.0...v0.7.1)

Updates `express` from 4.21.0 to 4.21.1
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/4.21.1/History.md)
- [Commits](expressjs/express@4.21.0...4.21.1)

---
updated-dependencies:
- dependency-name: cookie
  dependency-type: indirect
- dependency-name: express
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
@marcello33
chg: small fixes to guides / remove unused function
65504b8
@marcello33
Merge branch 'dependabot/npm_and_yarn/multi-9f37c16f8f' into mardizzo…
38974f0 
…ne/fixes
@marcello33 marcello33 mentioned this pull request Oct 16, 2024
Closed
@marcello33 marcello33 requested a review from a team October 16, 2024 09:44
@marcello33 marcello33 merged commit 94ec183 into master Oct 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pratikspatil024 pratikspatil024 pratikspatil024 approved these changes

@Raneet10 Raneet10 Raneet10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcello33 @Raneet10 @pratikspatil024