-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Formalizing the JobStore document format as a pydantic model #424
Conversation
Codecov Report
Additional details and impacted files
|
Hi @utf and @arosen93 , We have come up with some tests to check:
|
…ain consitency with the name of it's test file
Thanks! Linking this to #422 (as a note to future me) in case Pydantic 2 breaks things later. |
@mkhorton , @mcgalcode : I've implemented the suggestions that were made here in #425 |
description="The name of the job.", | ||
) | ||
|
||
@validator("output", pre=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @hrushikesh-s, please can you update this to Pydantic2 syntax, as discussed here: #425 (comment) (if it needs updating, if not, then just give me the go-ahead that I can merge).
Hi @utf, the |
Great, thanks for this. |
Thanks for adding the suggested code @hrushikesh-s! Only just saw this was merged, appreciated your efforts on this :) |
Summary
Include a summary of major changes in bullet points:
pydantic model
in place ofdictionary
Checklist
Work-in-progress pull requests are encouraged, but please put [WIP] in the pull request
title.
Before a pull request can be merged, the following items must be checked:
The easiest way to handle this is to run the following in the correct sequence on
your local machine. Start with running black on your new code. This will
automatically reformat your code to PEP8 conventions and removes most issues. Then run
pycodestyle, followed by flake8.
Run pydocstyle on your code.
type check your code.
Note that the CI system will run all the above checks. But it will be much more
efficient if you already fix most errors prior to submitting the PR. It is highly
recommended that you use the pre-commit hook provided in the repository. Simply
cp pre-commit .git/hooks
and a check will be run prior to allowing commits.