Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JobStoreDocument validator #478

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Fix JobStoreDocument validator #478

merged 1 commit into from
Nov 8, 2023

Conversation

utf
Copy link
Member

@utf utf commented Nov 8, 2023

I found that the validator in the JobStoreDocument introduced in #424 was causing atomate2 to stop working. I can't see why this validator is actually needed, it will just slow things down, so I removed it.

@utf utf added the fix Bug fix label Nov 8, 2023
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #478 (66296ea) into main (beb78b1) will decrease coverage by 0.01%.
Report is 4 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #478      +/-   ##
==========================================
- Coverage   99.86%   99.86%   -0.01%     
==========================================
  Files          20       20              
  Lines        1516     1508       -8     
  Branches      419      415       -4     
==========================================
- Hits         1514     1506       -8     
  Misses          2        2              
Files Coverage Δ
src/jobflow/core/job.py 100.00% <100.00%> (ø)
src/jobflow/core/schemas.py 100.00% <100.00%> (ø)
src/jobflow/core/store.py 100.00% <ø> (ø)

@utf utf merged commit 5508c2a into main Nov 8, 2023
8 checks passed
@utf utf deleted the fix-job-store-document branch December 10, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant