Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react_person #2368

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

react_person #2368

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cdfbbdb
react_person
Yaroslav65 May 19, 2024
100f198
fix errors
Yaroslav65 May 20, 2024
32fdc64
fix
Yaroslav65 May 20, 2024
7ec76d6
fixing errors
Yaroslav65 May 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 4 additions & 16 deletions src/App.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import React from 'react';
import './App.scss';
import { Person } from './components/Person/Person';

export const misha = {
name: 'Misha',
Expand All @@ -25,21 +26,8 @@ export const alex = {

export const App = () => (
<div className="App">
<section className="Person">
<h2 className="Person__name">My name is Misha</h2>
<p className="Person__age">I am 37</p>
<p className="Person__partner">Natasha is my wife</p>
</section>

<section className="Person">
<h2 className="Person__name">My name is Olya</h2>
<p className="Person__partner">Maksym is my husband</p>
</section>

<section className="Person">
<h2 className="Person__name">My name is Alex</h2>
<p className="Person__age">I am 25</p>
<p className="Person__partner">I am not married</p>
</section>
<Person person={misha} />
<Person person={olya} />
<Person person={alex} />
</div>
);
17 changes: 0 additions & 17 deletions src/App.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,3 @@
iframe {
display: none;
}

.Person {
width: fit-content;
margin-bottom: 16px;
padding: 8px;
border: 1px solid #000;
border-radius: 8px;

&__name {
margin-top: 8px;
}

&__age {
color: #00f;
font-weight: bold;
}
}
28 changes: 27 additions & 1 deletion src/components/Person/Person.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,27 @@
// export const Person = ({ person }) => ();
import './Person.scss';

const Married = ({ person }) => {
if (person.isMarried === false) {
return <p>I am not married</p>;
}

if (person.sex === 'f') {
return <p>{person.partnerName} is my husband</p>;
}

return <p>{person.partnerName} is my wife</p>;
};

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better to write it directly in Person, using ternary operators

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, I already tried to do this but there was one error in the linter when I used two ternary operators (? : ? : )there was something like a wrong rule, although everything worked

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's why I put it in a function so that there is no error in the linter

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better to write it directly in Person, using ternary operators

is this error - 12:8 error Do not nest ternary expressions no-nested-ternary

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can just move some condition in variable and reuse in ternary operator

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can just move some condition in variable and reuse in ternary operator

thanks for helps))

export const Person = ({ person }) => (
<section className="Person">
<h2 className="Person__name">{`My name is ${person.name}`}</h2>
{person.age !== undefined ? (
<p className="Person__age">
<p>{`I am ${person.age}`}</p>
</p>
) : null}
<p className="Person__partner">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{person.age !== undefined ? (
<p className="Person__age">
<p>{`I am ${person.age}`}</p>
</p>
) : null}
{person.age && (
<p className="Person__age">
<p>{`I am ${person.age}`}</p>
</p>
)}

<Married person={person} />
</p>
</section>
);
16 changes: 16 additions & 0 deletions src/components/Person/Person.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
.Person {
width: fit-content;
margin-bottom: 16px;
padding: 8px;
border: 1px solid #000;
border-radius: 8px;

&__name {
margin-top: 8px;
}

&__age {
color: #00f;
font-weight: bold;
}
}
Loading