react_person

[Yaroslav65]

No description provided.

[etojeDenys]

Suggested change

	{person.age !== undefined ? (
	<p className="Person__age">
	<p>{`I am ${person.age}`}</p>
	</p>
	) : null}
	{person.age && (
	<p className="Person__age">
	<p>{`I am ${person.age}`}</p>
	</p>
	)}

[etojeDenys]

better to write it directly in Person, using ternary operators

[Yaroslav65]

I agree, I already tried to do this but there was one error in the linter when I used two ternary operators (? : ? : )there was something like a wrong rule, although everything worked

[Yaroslav65]

That's why I put it in a function so that there is no error in the linter

[Yaroslav65]

better to write it directly in Person, using ternary operators

is this error - 12:8 error Do not nest ternary expressions no-nested-ternary

[etojeDenys]

you can just move some condition in variable and reuse in ternary operator

[Yaroslav65]

you can just move some condition in variable and reuse in ternary operator

thanks for helps))

[etojeDenys]

feel free to ask for some help in the chat

[etojeDenys]

you can just move some condition in variable and reuse in ternary operator

[Yaroslav65]

feel free to ask for some help in the chat

please double check my code

[vadiimvooo]

Good job. Last thing to fix.

[vadiimvooo]

Suggested change

	export const Person = ({ person }) => (
	<section className="Person">
	<h2 className="Person__name">{`My name is ${person.name}`}</h2>
	{person.age && (
	<p className="Person__age">
	<p>{`I am ${person.age}`}</p>
	</p>
	)}
	<p className="Person__partner">
	{person.isMarried === false ? (
	<p>I am not married</p>
	) : person.sex === 'f' ? (
	<p>{person.partnerName} is my husband</p>
	) : (
	<p>{person.partnerName} is my wife</p>
	)}
	</p>
	</section>
	export const Person = ({ person }) => {
	const { name, age, sex, isMarried, partnerName } = person;
	const partner = sex === 'm' ? 'wife' : 'husband';
	const personPartner = isMarried
	? `${partnerName} is my ${partner}`
	: `I am not married`;
	return (<section className="Person">
	<h2 className="Person__name">{`My name is ${name}`}</h2>
	{age && (
	<p className="Person__age">
	<p>{`I am ${age}`}</p>
	</p>
	)}
	<p className="Person__partner">{personPartner}</p>
	</section>)
	}

[Yaroslav65]

thanks for helps))

[etojeDenys]

Suggested change

	{person.isMarried === false ? (
	<p>I am not married</p>
	) : (
	<p>
	{person.partnerName} is my {partner}
	</p>
	)}
	{person.isMarried === false ? (
	"I am not married"
	) : (
	`${person.partnerName} is my {partner}`
	)}

looks like redundant p tag

[etojeDenys]

awesome