Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not performance improvements :) #4989

Merged
merged 3 commits into from
Nov 28, 2024
Merged

Not performance improvements :) #4989

merged 3 commits into from
Nov 28, 2024

Commits on Nov 27, 2024

  1. merged_tree: avoid two unnecessary clones

    @martinvonz
    martinvonz committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    4e6b513 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2024

  1. store: make get_tree() functions take owned repo path 

    The function needs an owned value, so we might as well pass it one and
avoid a few clone calls.
    @martinvonz
    martinvonz committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    ad6b5cf View commit details
    Browse the repository at this point in the history

  2. test_merged_tree: avoid a temporary lifetime extension 

    I think it's just clearer to assign the owned value to the variable
than to assign a reference to a temporary value.
    @martinvonz
    martinvonz committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    3ca2ef2 View commit details
    Browse the repository at this point in the history