Not performance improvements :) #4989
Merged
+41
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinvonz
force-pushed
the
push-otvsoqyzolns
branch
from
9da9224
to
fe51742
Compare
thoughtpolice
approved these changes
Nov 27, 2024
martinvonz
force-pushed
the
push-otvsoqyzolns
branch
from
fe51742
to
d609783
Compare
The function needs an owned value, so we might as well pass it one and avoid a few clone calls.
I think it's just clearer to assign the owned value to the variable than to assign a reference to a temporary value.
martinvonz
force-pushed
the
push-otvsoqyzolns
branch
from
d609783
to
3ca2ef2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some little cleanups I noticed while trying to make some functions async
Checklist
If applicable:
CHANGELOG.md