Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update React to version 18 and other deps #890

Merged
merged 9 commits into from
Mar 21, 2024
Merged

Update React to version 18 and other deps #890

merged 9 commits into from
Mar 21, 2024

Conversation

HarelM
Copy link
Collaborator

@HarelM HarelM commented Mar 20, 2024

This PR aims at updating some packages.
I'll keep this in draft until I'll be more happy with the results.
Current setup seems to work, I'll let the CI run and see how bad this is.
Packages that needs to be updated/replaces:

Most of the changes here are related to types, which is good.

@HarelM HarelM changed the title Update React to version 18 Update React to version 18 and other deps Mar 20, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.23%. Comparing base (355b663) to head (055eb13).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #890   +/-   ##
=======================================
  Coverage   57.23%   57.23%           
=======================================
  Files         104      104           
  Lines        2932     2932           
  Branches      667      667           
=======================================
  Hits         1678     1678           
  Misses       1254     1254           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HarelM
Copy link
Collaborator Author

HarelM commented Mar 21, 2024

Firefox tests are failing due to the following issue:
cypress-io/cypress#29172

@HarelM
Copy link
Collaborator Author

HarelM commented Mar 21, 2024

Mostly up-to-date.
There's still a need to update some stale packages, which might prove harder than anticipated due to the fact that there might be a need to use a component library, which is a big effort.
So, this is out of scope for this PR.

@HarelM HarelM marked this pull request as ready for review March 21, 2024 14:52
@HarelM HarelM requested a review from nyurik March 21, 2024 14:52
Copy link
Member

@nyurik nyurik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@nyurik
Copy link
Member

nyurik commented Mar 21, 2024

is there a reason Firefox fails? should we keep that test?

@HarelM
Copy link
Collaborator Author

HarelM commented Mar 21, 2024

See my comment about Firefox.

@HarelM
Copy link
Collaborator Author

HarelM commented Mar 21, 2024

@birkskyum I need your input here in order to merge this as you commented out about a problem in one of the components...

@birkskyum
Copy link
Member

I'm not sure i understand the question - where did I write something?

@HarelM
Copy link
Collaborator Author

HarelM commented Mar 21, 2024

In #846 you wrote something related to React 18 and incompatibility...

@birkskyum
Copy link
Member

birkskyum commented Mar 21, 2024

I think it was npm that gave deprecation or version mismatch errors.

@birkskyum
Copy link
Member

birkskyum commented Mar 21, 2024

I wasn't able to get anything going, so you're way beyond where i came to.

@HarelM
Copy link
Collaborator Author

HarelM commented Mar 21, 2024

Ahh, I see, so this is related to legacy-peer-deps flag that I added in order to get around the react version mismatch.
I would like to remove it in the future if possible, but I'm not very optimistic as it requires a lot of effort in replacing these old libraries, and it's not that easy.
In any case, I'll merge this and see what feedback I get from users as the sanity tests that I did seems that things are working as expected and also the tests pass (on chrome) which is good news.

@HarelM HarelM merged commit ff15b77 into main Mar 21, 2024
7 of 8 checks passed
@HarelM HarelM deleted the update-deps branch March 21, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants