-
-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update React to version 18 and other deps #890
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #890 +/- ##
=======================================
Coverage 57.23% 57.23%
=======================================
Files 104 104
Lines 2932 2932
Branches 667 667
=======================================
Hits 1678 1678
Misses 1254 1254 ☔ View full report in Codecov by Sentry. |
Firefox tests are failing due to the following issue: |
Mostly up-to-date. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
is there a reason Firefox fails? should we keep that test? |
See my comment about Firefox. |
@birkskyum I need your input here in order to merge this as you commented out about a problem in one of the components... |
I'm not sure i understand the question - where did I write something? |
In #846 you wrote something related to React 18 and incompatibility... |
I think it was npm that gave deprecation or version mismatch errors. |
I wasn't able to get anything going, so you're way beyond where i came to. |
Ahh, I see, so this is related to |
This PR aims at updating some packages.
I'll keep this in draft until I'll be more happy with the results.
Current setup seems to work, I'll let the CI run and see how bad this is.
Packages that needs to be updated/replaces:
autocompete - The only warning left in the console is related to the autocomplete, which probably needs to be updated since it's a package that wasn't updated in the last 6 years.Switch from react-autocomplete to alternative #611Codemirror is also something that will need an update, but it looks too complicated at this point in time, so let's see how this goes.Upgrade codemirror #891react-aria-menubutton[react18] Replace react-aria-menubutton with react-select #846Most of the changes here are related to types, which is good.