-
-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[react18] Replace react-aria-menubutton with react-select #846
Comments
I think the path forward is first to use typescript, otherwise updating dependencies will cause things to break only in run time. |
that's a good idea, and awesome that it's possible to transition with vite in place. on that note react-select has proper typing too, but it's a good idea to use a component library |
Migration is complete, lint is complete, feel free to push this forward. |
@birkskyum I've created a PR to update react to version 18. Can you tell me what I should check in order to see the issue? |
This PR aims at updating some packages. I'll keep this in draft until I'll be more happy with the results. Current setup seems to work, I'll let the CI run and see how bad this is. Packages that needs to be updated/replaces: - [x] ~autocompete - The only warning left in the console is related to the autocomplete, which probably needs to be updated since it's a package that wasn't updated in the last 6 years.~ #611 - [x] ~Codemirror is also something that will need an update, but it looks too complicated at this point in time, so let's see how this goes.~ #891 - [ ] react-color - [x] ~react-aria-menubutton~ #846 - [ ] Others? Most of the changes here are related to types, which is good.
I tried to update react, and react-aria-menubutton complained it isn't compatible with latest react.
We should probably just swap it. Long story short react-aria-menubutton became less relevant in 2021 with the rise of downshift, which itself got overtaken by react-select last few years.
The text was updated successfully, but these errors were encountered: