-
-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Storybook, cleanups #860
Conversation
@HarelM could you clarify what is the storybook and why we don't need it? |
It's mentioned in the channel. |
Thx for explanation. We should not rely on Slack channels to document our changes to the code, so lets make sure each change has clear explanation in the top comment of why it is being done - most people will have no idea there was a channel discussion when looking in the history of the project |
Can I merge this? |
Please update the first comment with the in-depth explanation of this change, and why it is not needed. This way that comment will go into the code's history, and can be easily viewed by anyone using git blame / viewing git log messages |
Updated the initial post. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! feel free to merge
It's a powerful tool for developing component library with "live" documentation.
But it's an overkill for this project and I would like to reduce maintenance costs.
Currently all the "stories" are in javascript and not in typescript and it feels like a waste of time to try and maintain it, along with updating the storybook library itself and everything around it.