Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove storybook #849

Closed
HarelM opened this issue Dec 21, 2023 · 1 comment
Closed

Remove storybook #849

HarelM opened this issue Dec 21, 2023 · 1 comment

Comments

@HarelM
Copy link
Collaborator

HarelM commented Dec 21, 2023

As part of my effort to upgrade the library I'm migrating the code to typescript.
See for example #848.
When looking into the repo I couldn't understand why the storybook is needed.
It is not exposed externally, and this is not a component library that really needs this.

So I'm looking for reasons not to delete it.
If you can think of any please let me know, otherwise I'll simply remove it and reduce maintenance efforts revolving this.
@HarelM
Copy link
Collaborator Author

HarelM commented Jan 12, 2024

Fixed by:

@HarelM HarelM closed this as completed Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@HarelM