Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused code #90

Merged
merged 1 commit into from
Aug 14, 2024
Merged

remove unused code #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 0 additions & 42 deletions MapboxCoreNavigation/CoreFeedbackEvent.swift
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion MapboxCoreNavigation/MMEEventsManager.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import AVFoundation
import MapboxDirections
import Polyline
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused import.

import UIKit

let SecondsBeforeCollectionAfterFeedbackEvent: TimeInterval = 20
Expand Down
1 change: 0 additions & 1 deletion MapboxCoreNavigation/RouteController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import CoreLocation
import Foundation
import MapboxDirections
import Polyline
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused import.

import Turf
import UIKit

Expand Down Expand Up @@ -672,7 +671,7 @@
if let _ = error { return }
guard let httpResponse = response as? HTTPURLResponse, httpResponse.statusCode == 200 else { return }

guard let data, let currentVersion = String(data: data, encoding: .utf8)?.trimmingCharacters(in: .newlines) else { return }

Check warning on line 674 in MapboxCoreNavigation/RouteController.swift

View workflow job for this annotation

GitHub Actions / Code Style 

Prefer using UTF-8 encoded strings when converting between `String` and `Data` (non_optional_string_data_conversion)

if latestVersion != currentVersion {
let updateString = NSLocalizedString("UPDATE_AVAILABLE", bundle: .mapboxCoreNavigation, value: "Mapbox Navigation SDK for iOS version %@ is now available.", comment: "Inform developer an update is available")
Expand Down
Loading