Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused code #90

Merged
merged 1 commit into from
Aug 14, 2024
Merged

remove unused code #90

merged 1 commit into from
Aug 14, 2024

Conversation

michaelkirk
Copy link
Collaborator

MapboxCoreNavigation/CoreFeedbackEvent.swift is a vestige of the telemetry stuff which was removed in several commits, including 62e6415

@michaelkirk michaelkirk mentioned this pull request Jul 29, 2024
@@ -1,6 +1,5 @@
import AVFoundation
import MapboxDirections
import Polyline
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused import.

@@ -1,7 +1,6 @@
import CoreLocation
import Foundation
import MapboxDirections
import Polyline
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused import.

Copy link
Contributor

@ianthetechie ianthetechie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; thanks!

@ianthetechie
Copy link
Contributor

Oh I guess I'm not a write access contributor so that doesn't count for much :P Any objections from you @boldtrn?

Copy link
Collaborator

@hactar hactar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hactar hactar merged commit 446aecc into main Aug 14, 2024
2 checks passed
@hactar hactar deleted the mkirk/remove-unused-polyline branch August 14, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants