Improve handling of system ICU on Linux #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntadej
force-pushed
the
icu
branch
13 times, most recently
from
a2c1c93 to
4b33e39
Compare
|
@FinitelyFailed, can you try if this PR fixes your issues with ICU? |
|
@ntadej It works nicely, thanks. :) I generate the config like this: I.e. not using -DMLN_QT_WITH_INTERNAL_ICU=ON. Which builds fine. |
This was referenced Oct 30, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a hacky solution to ignore Qt-provided ICU (maplibre/maplibre-native#1813, for now in the staging branch) and also add disclaimer to the README.