Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of ICU on Linux #39

Closed
1 of 3 tasks
ntadej opened this issue Oct 11, 2023 · 2 comments
Closed
1 of 3 tasks

Improve handling of ICU on Linux #39

ntadej opened this issue Oct 11, 2023 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@ntadej
Copy link
Collaborator

ntadej commented Oct 11, 2023

Only Linux uses ICU for bidirectional text (and related functionality). This causes issues with building. While we should keep compatibility with Qt binaries we should also make it easier for distribution users:

  • Make sure that internal ICU is not used when not selected.
  • Test builds with internal ICU and the effect on size.
  • Make sure that Qt6 binaries are still compatible.

/cc @petricf @emericg

@ntadej
Copy link
Collaborator Author

ntadej commented Oct 30, 2023

ICU handling has been improved with #56 so now there should be no build issues. More investigation still needs to be done though.

@emericg
Copy link

emericg commented Nov 15, 2023

I tested this with Qt 6.6 (linux, and android as well too actually, works very well).
The internal ICU usage is only adding about 300 kb to libQMapLibre (out of 11.2-5 mb) and both internal or system ICU builds are working.

@ntadej ntadej added this to the 3.0 milestone Apr 18, 2024
@ntadej ntadej added the enhancement New feature or request label Apr 18, 2024
@ntadej ntadej closed this as completed Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants