-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactored codebase a/c napoleon style #979
base: master
Are you sure you want to change the base?
Conversation
@mr-tz @williballenthin I have made changes using the isort , for the code style. |
please fix isort/black issues first |
Corrected the isort and black issues @mr-tz |
code style looks good now, this will take a bit to go through also other tests fail, need to look into those |
Can you look into the test failures, please? |
@mr-tz Sure ill look into it. |
Can you rebase this to master to (maybe) fix the test failures, please? Otherwise, we have to look closer at them. |
@mr-tz Sure i will take a look. |
2ce601e
to
a0ee25a
Compare
@RahulSankhla312 do you know what's failing here? |
@RahulSankhla312 another ping, otherwise we may have to close this here |
name: CI on: Save workspaces to speed up testingenv: jobs: tests: |
Changed the whole codebase Refactored codebase to consistently use Napoleon-style docstrings.
Improves code readability and maintainability by providing clear function and class descriptions.