Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactored codebase a/c napoleon style #979

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

RahulSankhla312
Copy link
Contributor

Changed the whole codebase Refactored codebase to consistently use Napoleon-style docstrings.
Improves code readability and maintainability by providing clear function and class descriptions.

@RahulSankhla312
Copy link
Contributor Author

@mr-tz @williballenthin I have made changes using the isort , for the code style.

@mr-tz
Copy link
Collaborator

mr-tz commented Mar 19, 2024

please fix isort/black issues first

@RahulSankhla312
Copy link
Contributor Author

Corrected the isort and black issues @mr-tz

@mr-tz
Copy link
Collaborator

mr-tz commented Mar 19, 2024

code style looks good now, this will take a bit to go through

also other tests fail, need to look into those

@mr-tz
Copy link
Collaborator

mr-tz commented Mar 20, 2024

Can you look into the test failures, please?

@RahulSankhla312
Copy link
Contributor Author

@mr-tz Sure ill look into it.

@mr-tz
Copy link
Collaborator

mr-tz commented Apr 26, 2024

Can you rebase this to master to (maybe) fix the test failures, please? Otherwise, we have to look closer at them.

@RahulSankhla312
Copy link
Contributor Author

@mr-tz Sure i will take a look.

@mr-tz
Copy link
Collaborator

mr-tz commented Jun 27, 2024

@RahulSankhla312 do you know what's failing here?

@mr-tz
Copy link
Collaborator

mr-tz commented Sep 23, 2024

@RahulSankhla312 another ping, otherwise we may have to close this here

@Abhishekjc19
Copy link

name: CI

on:
push:
branches: [ master ]
pull_request:
branches: [ master ]

Save workspaces to speed up testing

env:
FLOSS_SAVE_WORKSPACE: "True"

jobs:
code_style:
runs-on: ubuntu-20.04
steps:
- name: Checkout FLOSS
uses: actions/[email protected]
- name: Set up Python 3.8
uses: actions/[email protected]
with:
python-version: '3.8'
- name: Install dependencies
run: pip install -e .[dev]
- name: Lint with isort
run: pre-commit run isort --all-files
- name: Lint with black
run: pre-commit run black --all-files
- name: Check types with mypy
run: pre-commit run mypy --all-files

tests:
name: Tests in ${{ matrix.python-version }} on ${{ matrix.os }}
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
os: [ubuntu-20.04, windows-2019, macos-11]
python-version: ['3.8', '3.9', '3.10', '3.11']
steps:
- name: Checkout FLOSS with submodules
uses: actions/[email protected]
with:
submodules: true
- name: Set up Python ${{ matrix.python-version }}
uses: actions/[email protected]
with:
python-version: ${{ matrix.python-version }}
- name: Install pyyaml (Ubuntu)
if: matrix.os == 'ubuntu-20.04'
run: sudo apt-get install -y libyaml-dev
- name: Install FLOSS
run: pip install -e .[dev]
- name: Run tests
run: pytest tests/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants