Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use napoleon style docstrings #395

Open
williballenthin opened this issue Jul 21, 2021 · 8 comments
Open

use napoleon style docstrings #395

williballenthin opened this issue Jul 21, 2021 · 8 comments
Milestone

Comments

@williballenthin
Copy link
Collaborator

https://pypi.org/project/sphinxcontrib-napoleon/

@williballenthin williballenthin added this to the v2.0.0 milestone Jul 21, 2021
@mr-tz mr-tz modified the milestones: v2.0.0, vnext Mar 18, 2022
@RahulSankhla312
Copy link
Contributor

RahulSankhla312 commented Mar 15, 2024

@williballenthin Could you please explain more about this issue ?

@williballenthin
Copy link
Collaborator Author

this issue tracks the idea of using the doctoring style linked above throughout the code base. to close the issue, the contributor would review the entire floss codebase and fix any violations, migrating from the old style to the napoleon style.

note that we'd also prefer to use type annotations when possible, keeping these out of the docstring.

@RahulSankhla312
Copy link
Contributor

image image @williballenthin Should i do this type of napolean style to the whole codebase ?

@williballenthin
Copy link
Collaborator Author

please use the napoleon style, which is more like

args:
  foo: the foo thing
  bar: a bar for use

returns: xyz 

@RahulSankhla312
Copy link
Contributor

image Will like this be okay ? @williballenthin

@williballenthin
Copy link
Collaborator Author

looks great!

@RahulSankhla312
Copy link
Contributor

@williballenthin Sure ill make the changes in the whole codebase.

@RahulSankhla312
Copy link
Contributor

#979 Please review this PR
@mr-tz @williballenthin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants