Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Windows Terminal as pinned console #962

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Conversation

emtuls
Copy link
Member

@emtuls emtuls commented Mar 28, 2024

This sets Windows Terminal as the pinned console. It will also require merging the PR (mandiant/flare-vm#580) in flare-vm that modifies the CustomStartLayout.xml to pin Windows Terminal instead of the command prompt.

I also had to modify VM-Install-Shortcut to allow for regular shortcuts to also include arguments with their execution, which was required for an admin Windows Terminal to be able to start in a directory that we want, since the "Working Directory" does not work for shortcuts that are set to run as admin.

@emtuls emtuls added 💎 enhancement It is working, but it could be better 🌀 FLARE-VM A package or feature to be used by FLARE-VM labels Mar 28, 2024
@emtuls emtuls self-assigned this Mar 28, 2024
@emtuls emtuls requested a review from Ana06 March 28, 2024 02:25
Copy link
Member

@Ana06 Ana06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should remove the current Cmd Here and enable it in the Windows Terminal package in this PR. I think it should be run with admin rights, as we want admin rights to run malware.

packages/common.vm/tools/vm.common/vm.common.psm1 Outdated Show resolved Hide resolved
packages/installer.vm/tools/chocolateyinstall.ps1 Outdated Show resolved Hide resolved
@emtuls emtuls force-pushed the windows-terminal-default branch 2 times, most recently from 83292aa to daeb3d8 Compare March 29, 2024 04:44
Copy link
Member

@Ana06 Ana06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and works nicely. I have added some improvements suggestions.

@emtuls emtuls force-pushed the windows-terminal-default branch 3 times, most recently from 172cfd6 to f79ec1c Compare April 2, 2024 17:19
@emtuls emtuls force-pushed the windows-terminal-default branch from f79ec1c to 985717e Compare April 2, 2024 17:22
@emtuls emtuls requested a review from Ana06 April 2, 2024 17:25
Copy link
Member

@Ana06 Ana06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the work @emtuls!

@Ana06 Ana06 merged commit b2c59f2 into main Apr 3, 2024
6 checks passed
@emtuls emtuls deleted the windows-terminal-default branch April 3, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌀 FLARE-VM A package or feature to be used by FLARE-VM 💎 enhancement It is working, but it could be better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants