-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set Windows Terminal as pinned console #962
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should remove the current Cmd Here
and enable it in the Windows Terminal package in this PR. I think it should be run with admin rights, as we want admin rights to run malware.
83292aa
to
daeb3d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally and works nicely. I have added some improvements suggestions.
172cfd6
to
f79ec1c
Compare
f79ec1c
to
985717e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the work @emtuls!
This sets Windows Terminal as the pinned console. It will also require merging the PR (mandiant/flare-vm#580) in
flare-vm
that modifies theCustomStartLayout.xml
to pin Windows Terminal instead of the command prompt.I also had to modify
VM-Install-Shortcut
to allow for regular shortcuts to also include arguments with their execution, which was required for an admin Windows Terminal to be able to start in a directory that we want, since the "Working Directory" does not work for shortcuts that are set to run as admin.