Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Windows Terminal the default to run console apps #971

Open
Ana06 opened this issue Apr 2, 2024 · 4 comments · May be fixed by #1093
Open

Make Windows Terminal the default to run console apps #971

Ana06 opened this issue Apr 2, 2024 · 4 comments · May be fixed by #1093
Assignees
Labels
💎 enhancement It is working, but it could be better ❔ discussion Further discussion is needed

Comments

@Ana06
Copy link
Member

Ana06 commented Apr 2, 2024

Details

Since mandiant/flare-vm#580 and #962, Windows Terminal is the default console in FLARE-VM, being adding to the right-click and to the taskbar. @mandiant/vms should we also make Windows Terminal the default console to run tools as console apps? Currently the default is cmd for most tool and powershell for ps1 scripts.

@Ana06 Ana06 added 💎 enhancement It is working, but it could be better ❔ discussion Further discussion is needed labels Apr 2, 2024
@day1player
Copy link
Contributor

I am in favor!

@d35ha d35ha self-assigned this Jun 11, 2024
@d35ha
Copy link
Member

d35ha commented Jun 13, 2024

@Ana06
This feature is only available in windows 11 or an updated version of windows 10.
The required OS build is >= 19045.3031.

@d35ha d35ha linked a pull request Jun 14, 2024 that will close this issue
@Ana06
Copy link
Member Author

Ana06 commented Jul 1, 2024

What do you mean with "this feature"? We want to open the shortcuts in the Tools directory with the Windows terminal, this is something we should be able to do in all versions.

I am using 10.0.19045.0 (downloaded from the recommended link in FLARE-VM), so we need to support this version as well.

@d35ha
Copy link
Member

d35ha commented Jul 1, 2024

@Ana06
The default terminal host in windows is conhost.exe, for any application that requires a console (Ex. console apps like cmd.exe or GUI apps using AllocConsole) windows, by default, assigns the traditional console host to it.
Since our shortcuts are basically wrappers for cmd.exe commands, the used console is the old conhost.exe. cmd.exe itself is not a console, it's an app that requires a console.
To change the default console host in windows, the OS build should be >= 19045.3031 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💎 enhancement It is working, but it could be better ❔ discussion Further discussion is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants