Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package Fix: Microsoft-Windows-Terminal #936

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Package Fix: Microsoft-Windows-Terminal #936

merged 1 commit into from
Mar 5, 2024

Conversation

emtuls
Copy link
Member

@emtuls emtuls commented Mar 5, 2024 •
edited
Loading

This fixes #934 by just downloading the latest package from the github and using it directly.

I made a few other changes to this as well, like a name change from microsoft-windows-terminal to a more simple windows-terminal, which is what most people in the community call it anyway.

I had to do a custom installation instead of our helper functions due to needing runAsAdmin which is only supported by calling Install-Shortcut directly and not able to be done from VM-Install-From-Zip or VM-Install-Raw-GitHub-Repo.

@emtuls emtuls added the 🌀 FLARE-VM A package or feature to be used by FLARE-VM label Mar 5, 2024
@emtuls emtuls requested a review from Ana06 March 5, 2024 05:02
@emtuls emtuls self-assigned this Mar 5, 2024
@emtuls emtuls force-pushed the fix-windows-terminal branch from 10573cb to 601de62 Compare March 5, 2024 05:04
This was referenced Mar 5, 2024
Closed
Merged
Ana06
Ana06 reviewed Mar 5, 2024
View reviewed changes
Copy link
Member

@Ana06 Ana06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the package and it works perfectly. We should resolve the minor comment in the uninstaller and we are good to go.

@emtuls emtuls force-pushed the fix-windows-terminal branch from 601de62 to 5b1d0e6 Compare March 5, 2024 17:07
@emtuls emtuls force-pushed the fix-windows-terminal branch from 5b1d0e6 to 79bb2fc Compare March 5, 2024 17:13
@emtuls emtuls requested a review from Ana06 March 5, 2024 17:18
@Ana06
Copy link
Member

Ana06 commented Mar 5, 2024

Thanks for all the work @emtuls!

@Ana06 Ana06 merged commit 015801f into main Mar 5, 2024
6 checks passed
@Ana06 Ana06 mentioned this pull request Mar 5, 2024
Merged
@emtuls emtuls deleted the fix-windows-terminal branch March 5, 2024 22:35
@emtuls emtuls mentioned this pull request Apr 2, 2024
Open
@Ana06 Ana06 mentioned this pull request May 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ana06 Ana06 Ana06 approved these changes

Assignees

@emtuls emtuls

Labels
🌀 FLARE-VM A package or feature to be used by FLARE-VM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

microsoft-windows-terminal.vm is broken
2 participants
@emtuls @Ana06