[CI] Exclude microsoft-windows-terminal.vm from windows-2019 in the daily run

[Ana06]

What's the problem?

microsoft-windows-terminal.vm introduced in #876, does not install in windows-2019, reason why we decided to test it only in windows-2022. However in that PR we only excluded in ci.yml, but not in daily.yml, so the package is failing in the daily run.

Any ideas on what is the best way to implement this? I purpose we introduce a new parameter excluded_packages to the test_install.ps1 script to make it easier to exclude from both actions instead of duplicating code in the github actions.

Steps to Reproduce

Check the daily run results.

Environment

Daily run, windows-2019.

Additional Information

No response

Detected by test suite

Yes

[Ana06]

Since 2024-03-06, windows-terminal does not fail to install in the daily run, @emtuls have you change something related to this and I do not remember? 🕵️

[emtuls]

Interesting...

I did make a change to use the Github package instead of Chocolatey in #936 which I believe is that same time frame. Previously, their code would determine if the OS was of the correct version or not, so I wonder if this is something not working (or possibly changed) in their code in Github release vs Chocolatey.

The Github Repo still states: Windows Terminal requires Windows 10 2004 (build 19041) or later (https://github.com/microsoft/terminal?tab=readme-ov-file#installing-and-running-windows-terminal), which the Github Actions Windows-2019 Runner is not...The README for it states: OS Version: 10.0.17763 Build 5576 (https://github.com/actions/runner-images/blob/main/images/windows/Windows2019-Readme.md)

Daily run seems to say it installs fine: https://github.com/mandiant/VM-Packages/actions/runs/8166465011/job/22325257278#step:3:8084
Whereas before it didn't: https://github.com/mandiant/VM-Packages/actions/runs/8150554446/job/22277009226#step:3:4860

[emtuls]

If we were to add it to test_install.ps1, we could take advantage of the exclude_tests that already exists in it (https://github.com/mandiant/VM-Packages/blob/main/scripts/test/test_install.ps1#L42), but we will also need to have a parameter added to determine which OS version we are running a test on so that we can filter appropriately.

We would likely only want to only filter if something is passed in to make sure that we can use the script locally on any version of Windows, and only filter based on the test environment on Github, where it would pass in either windows-2019 or windows-2022.

[Ana06]

So I understand we can close this issue as the daily is working and all we need to do is to remove the old exclusion (tracked in #1062). Is that right @emtuls? If not, please reopen the issue.