Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package proposal: magika #935

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Package proposal: magika #935

merged 1 commit into from
Apr 10, 2024

Conversation

emtuls
Copy link
Member

@emtuls emtuls commented Mar 4, 2024

This package is an awesome open source utility that can detect file formats much faster and better than the standard file utility that we currently use.

https://github.com/google/magika

@emtuls emtuls added 💎 enhancement It is working, but it could be better 🆕 package New package request/idea/PR 🌀 FLARE-VM A package or feature to be used by FLARE-VM labels Mar 4, 2024
@emtuls emtuls requested a review from Ana06 March 4, 2024 21:13
@emtuls emtuls self-assigned this Mar 4, 2024
Copy link
Member

@Ana06 Ana06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think magika should be its own package and not part of the python libraries. I think the magika package should create a shortcut for it.

Related #695

@emtuls
Copy link
Member Author

emtuls commented Mar 5, 2024

@Ana06 pip seems to produce an error even though everything installs correctly, causing an issue with the package saying that it installed incorrectly and will stop due to $ErrorActionPreference = 'Stop'

I attempted to copy what was done in libraries.python3.vm, but it did not work unless I changed $ErrorActionPreference = 'Continue' at the top.

Do you have any suggestions on other ways to mitigate this? If this is the only way, then I will have to add an Exclusion inside of lint.py and this will also be something that needs to be done for all future packages that install a tool via pip.

@emtuls emtuls requested a review from Ana06 March 5, 2024 19:54
@emtuls emtuls force-pushed the package-magika branch 2 times, most recently from c40ceec to 078dfe8 Compare March 6, 2024 03:04
packages/magika.vm/magika.vm.nuspec Show resolved Hide resolved
packages/magika.vm/tools/chocolateyinstall.ps1 Outdated Show resolved Hide resolved
packages/magika.vm/tools/chocolateyinstall.ps1 Outdated Show resolved Hide resolved
packages/magika.vm/tools/chocolateyinstall.ps1 Outdated Show resolved Hide resolved
packages/magika.vm/tools/chocolateyinstall.ps1 Outdated Show resolved Hide resolved
packages/magika.vm/magika.vm.nuspec Outdated Show resolved Hide resolved
@emtuls emtuls force-pushed the package-magika branch 6 times, most recently from 48c6607 to 4bed168 Compare April 10, 2024 00:25
Copy link
Member

@Ana06 Ana06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emtuls can you use the authors from the project page? Apart from that LGTM

packages/magika.vm/magika.vm.nuspec Outdated Show resolved Hide resolved
@emtuls emtuls requested a review from Ana06 April 10, 2024 10:29
@Ana06 Ana06 merged commit 5dcdd11 into main Apr 10, 2024
6 checks passed
@emtuls emtuls deleted the package-magika branch April 10, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌀 FLARE-VM A package or feature to be used by FLARE-VM 💎 enhancement It is working, but it could be better 🆕 package New package request/idea/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants