Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libraries.python3.vm with new function #945

Closed
emtuls opened this issue Mar 6, 2024 · 0 comments · Fixed by #946
Closed

Update libraries.python3.vm with new function #945

emtuls opened this issue Mar 6, 2024 · 0 comments · Fixed by #946
Assignees

Comments

@emtuls
Copy link
Member

emtuls commented Mar 6, 2024

Details

From #935 (comment), there is a need to standardize the location of our python installation logs.

Currently, libraries.python3.vm uses $(Split-Path -parent $MyInvocation.MyCommand.Definition) to determine where to store its log, which leads to C:\ProgramData\chocolatey\lib\libraries.python3.vm\tools. This seems like an odd location and not somewhere I would check for log data related to installing things.
We have a dedicated folder called C:\ProgramData\_VM that we claim we should put logs into, so this seems like the best place to store them.

Also noted, libraries.python3.vm has a dependency of vcbuildtools.vm, which only seems to be necessary for a single library (acefile) and causes this package to take much longer to install. I think it might be worth separating that library into its own package at a later time if this becomes an issue/annoyance.

@emtuls emtuls self-assigned this Mar 6, 2024
@emtuls emtuls changed the title Update libraries.python3.vm with new function and remove unnecessary dependency Update libraries.python3.vm with new function and remove dependency Apr 10, 2024
@emtuls emtuls changed the title Update libraries.python3.vm with new function and remove dependency Update libraries.python3.vm with new function Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant