Ensure VM-Remove-DesktopFiles deletes as many files as possible #754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4ce4958. We can't delete PS_Transcripts while Powershell is open and `VM-Clean-Up` is a PowerShell function.
We set `$ErrorActionPreference = 'Stop'` at the beginning of the file, causing that a problem removing an item automatically stops without deleting other files in `VM-Remove-DesktopFiles` (called from `VM-Clean-Up`). We want to ensure the `catch` in this function is used deleting as many files as possible.
mr-tz
approved these changes
Nov 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to add the deleting of
PS_Transcriptsin 4ce4958. But we can't delete PS_Transcripts while Powershell is open andVM-Remove-DesktopFiles/VM-Clean-Upare PowerShell functions. I have open #755 to discuss if there is another way to achieve this.This has reveled another important issue: We set
$ErrorActionPreference = 'Stop'at the beginning of the file,causing that a problem removing an item automatically stops without deleting other files in
VM-Remove-DesktopFiles(called fromVM-Clean-Up). We want to ensure thecatchin this function is used deleting as many files as possible. Fix this here using-ErrorAction Continue. I also think this may be a more general issue we should discuss in #753