Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete PS_Transcripts in VM-Remove-DesktopFiles #755

Closed
Ana06 opened this issue Nov 24, 2023 · 4 comments · Fixed by #816
Closed

Delete PS_Transcripts in VM-Remove-DesktopFiles #755

Ana06 opened this issue Nov 24, 2023 · 4 comments · Fixed by #816
Labels
❔ discussion Further discussion is needed

Comments

@Ana06
Copy link
Member

Ana06 commented Nov 24, 2023

Details

I would like to delete the PS_Transcripts folder in the VM-Remove-DesktopFiles function (called by VM-Clean-Up) as I want to delete any log files (including PowerShell logs) when executing this function. However, as explained in #754, deleting PS_Transcripts while Powershell is open is an issue as VM-Remove-DesktopFiles/VM-Clean-Up are PowerShell functions. @emtuls any ideas how we could do this? I wouldn't like to complicate it the logic/code too much, but it would be nice to have.

@Ana06
Copy link
Member Author

Ana06 commented Nov 24, 2023

One relatively simple idea is to delete files in the directory if deleting the whole directory is not possible, this may delete part of the files in PS_Transcripts

@day1player
Copy link
Contributor

I remember us discussing this in #706 , I think maybe we should just move PS_Transcripts folder to the Start Menu

@Ana06
Copy link
Member Author

Ana06 commented Jan 4, 2024

@day1player some FLARE-VM users seem to find the PS_Transcripts folder in the Desktop useful. We want to keep it, but deleting the installation logs by running VM-Clean-Up after the installation.

@day1player
Copy link
Contributor

Ok got it, that makes sense!

@Ana06 Ana06 closed this as completed in #816 Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
❔ discussion Further discussion is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants