Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve VM-Clean-Up #816

Merged
merged 3 commits into from
Jan 4, 2024
Merged

Improve VM-Clean-Up #816

merged 3 commits into from
Jan 4, 2024

Conversation

Ana06
Copy link
Member

@Ana06 Ana06 commented Jan 4, 2024

  • Exclude Recycle Bin in VM-Remove-DesktopFiles as it keeps the files
    deleted from the Desktop, which is a confusing behavior. Instead clean
    the recycle bin explicitly in VM-Clean-Up.
  • Delete saved PowerShell history in VM-Clean-Up by deleting the file
    that contains it.
  • Remove as much of PS_Transcripts as possible in
    VM-Remove-DesktopFiles (called by VM-Clean-Up).

Closes #755

@Ana06 Ana06 added 💎 enhancement It is working, but it could be better 🌀 FLARE-VM A package or feature to be used by FLARE-VM labels Jan 4, 2024
@Ana06 Ana06 requested a review from emtuls January 4, 2024 17:17
@Ana06 Ana06 self-assigned this Jan 4, 2024
Ana06 added 3 commits January 4, 2024 18:22
@Ana06
[common.vm] Clear Recycle Bin in VM-Clean-Up
c91c2b8 
Exclude `Recycle Bin` in `VM-Remove-DesktopFiles` as it keeps the files
deleted from the Desktop, which is a confusing behavior. Instead clean
the recycle bin explicitly in `VM-Clean-Up`.
@Ana06
[common.vm] Clear shell History in VM-Clean-Up
7e76da7 
Delete saved PowerShell history in `VM-Clean-Up` by deleting the file
that contains it.
@Ana06
[common.vm] Remove PS_Transcripts in VM-Clean-Up
677a194 
Remove as much of `PS_Transcripts` as possible in
`VM-Remove-DesktopFiles` (called by `VM-Clean-Up`).
emtuls
emtuls approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@emtuls emtuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All look good! Thank you for adding all of this! 👍

@Ana06
Copy link
Member Author

Ana06 commented Jan 4, 2024

Thanks for the review @emtuls!

@Ana06 Ana06 merged commit 990b75d into mandiant:main Jan 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emtuls emtuls emtuls approved these changes

Assignees

@Ana06 Ana06

Labels
🌀 FLARE-VM A package or feature to be used by FLARE-VM 💎 enhancement It is working, but it could be better
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Delete PS_Transcripts in VM-Remove-DesktopFiles
2 participants
@Ana06 @emtuls