Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cyberchef] Improve CyberChef shortcut #1148

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Conversation

Ana06
Copy link
Member

@Ana06 Ana06 commented Oct 2, 2024

Improve the CyberChef shortcut to avoid duplication of CyberChef and Chrome in the taskbar.
image

After installing the package, restart the system to ensure it is working.

It partially addresses #1100. See #1100 (comment) for other considered options and more details.

Improve the CyberChef shortcut to avoid duplication of CyberChef and
Chrome in the taskbar.
@Ana06 Ana06 added 💎 enhancement It is working, but it could be better 🌀 FLARE-VM A package or feature to be used by FLARE-VM labels Oct 2, 2024
@Ana06 Ana06 requested a review from emtuls October 2, 2024 12:13
@Ana06 Ana06 self-assigned this Oct 2, 2024
@emtuls
Copy link
Member

emtuls commented Oct 7, 2024

Doesn't seem to work consistently for me. 🙁

First time I installed it, it didn't work at first, then after a few tries (of doing nothing different), it started to work. But then I reverted my snapshot and tried again, and couldn't get it to work at all, even with a restart of the system and also even just with restarting explorer.exe.

It sort of seems to work when I manually make a chrome shortcut, set the icon to cyberchef, then pin it and restart explorer.exe
Which is weird, because that's basically what you're doing in the package...

@Ana06
Copy link
Member Author

Ana06 commented Oct 7, 2024

Thanks for testing it @emtuls, @mandiant/vms can someone else test it?

Even if does not improve the CyberChef + Chrome icons in the taskbar, do we want to merge the modification as it simplifies the code and uses the VM-Install-Shortcut helper?

@Ana06 Ana06 merged commit 5395181 into mandiant:main Oct 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌀 FLARE-VM A package or feature to be used by FLARE-VM 💎 enhancement It is working, but it could be better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants