-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Chrome dependency in cyberchef.vm thank to new changes #1021
Comments
@Ana06 Looking at this some more, I can't get a To bypass this, we can attempt to use the tool we discussed here, called |
|
I may have a semi-working solution for this. It makes the popup not be displayed anymore, which means opening a I still need to test how this would work if chrome was not installed, but at least for the chrome case...
NOTE: This does not make |
Because of the changes in #1148, we can't remove the dependency |
Details
I think with the changes in #1016 we could now remove the Chrome dependency in Cyberchef and the code to open it with chrome and set the icon (simplifying the installer code). I think we would keep the current behavior if both cyberchef.vm and googlechrome.vm are installed and remove the chrome dependency would allow to have a different browser as default (and to open cyberchef) if only cyberchef.vm is installed. This would need to add googlechrome.vm explicitly in flare-vm.
@emtuls what do you think?
The text was updated successfully, but these errors were encountered: