Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manabie Challenge: Mana Do task for Frontend Engineer applicants #261

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Manabie Challenge: Mana Do task for Frontend Engineer applicants #261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
21b0e4a
updated reducer, fixed double entries of todos upon adding; fixed upd…
rysimbajon Apr 26, 2022
b14302c
Added edit todo, save functionality
rysimbajon Apr 28, 2022
b775572
added alert message
rysimbajon Apr 28, 2022
0a12d0f
updates: data to stored in local storage
rysimbajon Apr 29, 2022
ad896cf
updates
rysimbajon Apr 29, 2022
08e53d5
fixed localStorage fetch and update data, added function SET in reducer
rysimbajon May 4, 2022
c9e8155
added alerts/response
rysimbajon May 4, 2022
799c064
updated reducer and main todopage tsx
rysimbajon May 4, 2022
96539cc
update readme
rysimbajon May 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,21 @@
### Roberch Ryan Simbajon: Applicant: Frontend Engineer - Submitted (April 29, 2022)

Accomplished Tasks:
- Update of todo status
- Deleting of todo status
- Fixed a bug when adding task, it doubled upon enter
- LocalStorage implementation

How to run tests:
- npm i (install first dependencies used)
- yarn start:frontend

Things to add if given more time:
- Improve UI design, enhancements of layout, appearance, user ergonomics in interactive such web app
- Improve more in TypeScript implementions, coding standards(it's my first time to use TypeScript, learn and exam in the same time, I want to learn more in this platform, so while learning TypeScript, I just applied my learning concepts from React.js, which is very challenging in my part.)

#####

## Welcome to Manabie coding challenge

*Hello!*
Expand Down Expand Up @@ -41,3 +59,4 @@
- Sign in using username: `firstUser`, password: `example`

Last updated: 2022/01/13

Loading